From c7fadbcaf1653061180b40dfefc1a076e5df9846 Mon Sep 17 00:00:00 2001 From: Nicolas Drolet Date: Fri, 5 Dec 2025 17:01:57 -0500 Subject: [PATCH] fix(eslint): modified rules to finally stop screaming about unused vars even if they're preceded by an underscore --- eslint.config.js | 12 +++++++----- src/boot/axios.ts | 1 - src/env.d.ts | 2 -- .../employee-list/components/employee-list-table.vue | 3 +-- .../models/timesheet-overview.models.ts | 6 ------ src/router/router-constants.ts | 1 - src/stores/store-flag.d.ts | 1 - 7 files changed, 8 insertions(+), 18 deletions(-) diff --git a/eslint.config.js b/eslint.config.js index 5923a57..e1caa74 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -41,6 +41,11 @@ export default defineConfigWithVueTs( 'error', { prefer: 'type-imports' } ], + "no-unused-vars": "off", + '@typescript-eslint/no-unused-vars': [ + 'warn', + { argsIgnorePattern: '^_', varsIgnorePattern: '^_' } + ], } }, // https://github.com/vuejs/eslint-config-typescript @@ -70,11 +75,8 @@ export default defineConfigWithVueTs( 'prefer-promise-reject-errors': 'off', // warn about unused but underscored variables - "@typescript-eslint/no-unused-vars": "off", - 'no-unused-vars': [ - 'warn', - { argsIgnorePattern: '^_', varsIgnorePattern: '^_' } - ], + + 'no-unused-vars': 'off', // allow debugger during development only 'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off' diff --git a/src/boot/axios.ts b/src/boot/axios.ts index eb5145b..3ac8c4c 100644 --- a/src/boot/axios.ts +++ b/src/boot/axios.ts @@ -1,4 +1,3 @@ -/* eslint-disable */ import { defineBoot } from '#q-app/wrappers'; import axios, { type AxiosInstance } from 'axios'; diff --git a/src/env.d.ts b/src/env.d.ts index dd757b1..12dcd18 100644 --- a/src/env.d.ts +++ b/src/env.d.ts @@ -1,5 +1,3 @@ -/* eslint-disable */ - declare namespace NodeJS { interface ProcessEnv { NODE_ENV: string; diff --git a/src/modules/employee-list/components/employee-list-table.vue b/src/modules/employee-list/components/employee-list-table.vue index bd30821..5606742 100644 --- a/src/modules/employee-list/components/employee-list-table.vue +++ b/src/modules/employee-list/components/employee-list-table.vue @@ -2,7 +2,6 @@ setup lang="ts" > - /* eslint-disable */ import EmployeeListTableItem from 'src/modules/employee-list/components/employee-list-table-item.vue'; import { onMounted, ref } from 'vue'; @@ -24,7 +23,7 @@ hide_inactive_users: true, }); - const filterEmployeeRows = (rows: readonly EmployeeProfile[], terms: EmployeeListFilters): EmployeeProfile[] => { + const filterEmployeeRows = (rows: readonly EmployeeProfile[], terms: EmployeeListFilters, _cols: readonly QTableColumn[]): EmployeeProfile[] => { let result = [...rows]; if (terms.hide_inactive_users) { diff --git a/src/modules/timesheet-approval/models/timesheet-overview.models.ts b/src/modules/timesheet-approval/models/timesheet-overview.models.ts index 9689da7..62edb8c 100644 --- a/src/modules/timesheet-approval/models/timesheet-overview.models.ts +++ b/src/modules/timesheet-approval/models/timesheet-overview.models.ts @@ -1,11 +1,5 @@ import type { QTableColumn } from "quasar"; -/* eslint-disable */ -export enum NavigatorConstants { - NEXT_PERIOD = 1, - PREVIOUS_PERIOD = -1, -} - export interface TimesheetOverview { email: string; employee_name: string; diff --git a/src/router/router-constants.ts b/src/router/router-constants.ts index 9114cd2..eff5290 100644 --- a/src/router/router-constants.ts +++ b/src/router/router-constants.ts @@ -1,5 +1,4 @@ export enum RouteNames { - /* eslint-disable */ LOGIN = 'login', LOGIN_SUCCESS = 'login-success', DASHBOARD = 'dashboard', diff --git a/src/stores/store-flag.d.ts b/src/stores/store-flag.d.ts index 683e459..f516596 100644 --- a/src/stores/store-flag.d.ts +++ b/src/stores/store-flag.d.ts @@ -1,4 +1,3 @@ -/* eslint-disable */ // THIS FEATURE-FLAG FILE IS AUTOGENERATED, // REMOVAL OR CHANGES WILL CAUSE RELATED TYPES TO STOP WORKING import 'quasar/dist/types/feature-flag';