From 6c10cbb7fab3f5405cee6fc6814e2dcef4bc3275 Mon Sep 17 00:00:00 2001
From: Nic D <n_drolet@hotmail.ca>
Date: Thu, 22 Jan 2026 11:36:12 -0500
Subject: [PATCH] feat(timesheet): add delete confirmation for shift. Add blur
 filter to dialogs

---
 src/i18n/en-ca/index.ts                       |  2 +-
 src/i18n/fr-ca/index.ts                       |  2 +-
 .../components/details-dialog.vue             |  1 +
 .../timesheets/components/expense-dialog.vue  |  1 +
 .../components/shift-list-day-row.vue         | 39 ++++++++++++++++++-
 5 files changed, 42 insertions(+), 3 deletions(-)

diff --git a/src/i18n/en-ca/index.ts b/src/i18n/en-ca/index.ts
index d2d1823..1ab309c 100644
--- a/src/i18n/en-ca/index.ts
+++ b/src/i18n/en-ca/index.ts
@@ -295,7 +295,7 @@ export default {
                 add: "Add Shift",
                 edit: "Edit shift",
                 delete: "Delete shift",
-                delete_confirmation_msg: "Do you want to delete this shift completly?",
+                delete_confirmation_msg: "Delete this shift?",
             },
             types: {
                 label: "Shift`s Type",
diff --git a/src/i18n/fr-ca/index.ts b/src/i18n/fr-ca/index.ts
index 70c5d95..98c795b 100644
--- a/src/i18n/fr-ca/index.ts
+++ b/src/i18n/fr-ca/index.ts
@@ -295,7 +295,7 @@ export default {
                 add: "Ajouter un Quart",
                 edit: "Modifier un Quart",
                 delete: "Supprimer un Quart",
-                delete_confirmation_msg: "Voulez-vous complètement supprimer ce quart?",
+                delete_confirmation_msg: "Supprimer ce quart?",
             },
             types: {
                 label: "Type de Quart",
diff --git a/src/modules/timesheet-approval/components/details-dialog.vue b/src/modules/timesheet-approval/components/details-dialog.vue
index ccd539d..825eb35 100644
--- a/src/modules/timesheet-approval/components/details-dialog.vue
+++ b/src/modules/timesheet-approval/components/details-dialog.vue
@@ -22,6 +22,7 @@
         full-height
         transition-show="jump-down"
         transition-hide="jump-down"
+        backdrop-filter="blur(6px)"
         @show="is_dialog_open = true"
         @hide="is_dialog_open = false"
     >
diff --git a/src/modules/timesheets/components/expense-dialog.vue b/src/modules/timesheets/components/expense-dialog.vue
index 21ba93e..2171f8b 100644
--- a/src/modules/timesheets/components/expense-dialog.vue
+++ b/src/modules/timesheets/components/expense-dialog.vue
@@ -28,6 +28,7 @@
         v-model="expense_store.is_open"
         persistent
         :full-width="$q.platform.is.mobile"
+        backdrop-filter="blur(6px)"
         transition-show="jump-down"
         transition-hide="jump-down"
     >
diff --git a/src/modules/timesheets/components/shift-list-day-row.vue b/src/modules/timesheets/components/shift-list-day-row.vue
index 0636484..d752aff 100644
--- a/src/modules/timesheets/components/shift-list-day-row.vue
+++ b/src/modules/timesheets/components/shift-list-day-row.vue
@@ -19,6 +19,7 @@
     const shift_type_selected = ref(SHIFT_OPTIONS.find(option => option.value == shift.value.type));
     const select_ref = ref<QSelect | null>(null);
     const error_message = ref<string | undefined>();
+    const is_showing_delete_confirm = ref(false);
 
     const { errorMessage = undefined, isTimesheetApproved = false, holiday = false } = defineProps<{
         dense?: boolean;
@@ -69,6 +70,11 @@
         }
     };
 
+    const onConfirmDelete = () => {
+        is_showing_delete_confirm.value = false;
+        emit('requestDelete');
+    }
+
     const getCommentCounterColor = (comment_length: number) => {
         if (comment_length < 200) return 'primary';
         if (comment_length < 250) return 'warning';
@@ -87,6 +93,37 @@
 
 <template>
     <div :class="ui_store.is_mobile_mode ? 'column' : 'row'">
+        <!-- delete shift confirmation dialog -->
+        <q-dialog
+            v-model="is_showing_delete_confirm"
+            backdrop-filter="blur(6px)"
+        >
+            <div
+                class="column flex-center q-pa-md bg-secondary shadow-24 rounded-10"
+                style="border: 2px solid var(--q-accent);"
+            >
+                <span class="col-auto text-h6 text-bold text-uppercase">{{
+                    $t('timesheet.shift.actions.delete_confirmation_msg') }}</span>
+                <div class="row justify-right full-width">
+                    <q-btn
+                        flat
+                        color="negative"
+                        :label="$t('shared.misc.no')"
+                        class="col"
+                        @click="is_showing_delete_confirm = false"
+                    />
+
+                    <q-btn
+                        flat
+                        color="accent"
+                        :label="$t('shared.misc.yes')"
+                        class="col"
+                        @click="onConfirmDelete"
+                    />
+                </div>
+            </div>
+        </q-dialog>
+
         <div
             class="row items-center text-uppercase rounded-5"
             :class="ui_store.is_mobile_mode ? 'col q-mb-xs q-px-xs' : 'col-4'"
@@ -310,7 +347,7 @@
                     class="col"
                     size="1.2em"
                     :class="shift.is_approved ? 'invisible' : ''"
-                    @click="$emit('requestDelete')"
+                    @click="is_showing_delete_confirm = true"
                 >
                 </q-btn>
             </div>