From 3bf8c57f74eb49b0097a73ec8a32a529f53a8915 Mon Sep 17 00:00:00 2001 From: Nicolas Drolet Date: Fri, 26 Sep 2025 11:06:07 -0400 Subject: [PATCH 1/4] refactor(approvals): massive refactor of names, DRY component scripts, separation of concern, trim unnecessary code --- src/css/app.scss | 2 +- src/i18n/en-ca/index.ts | 1 + src/i18n/fr-ca/index.ts | 1 + .../components/main-layout-footer-bar.vue} | 0 .../main-layout-header-bar-notification.vue} | 0 .../components/main-layout-header-bar.vue} | 4 +- .../components/main-layout-left-drawer.vue} | 12 +- src/layouts/main-layout.vue | 6 +- src/modules/shared/components/auto-logout.vue | 0 .../components/dialogs/dialog-account.vue | 0 .../dialogs/dialog-notification.vue | 0 .../dialogs/dialog-template-shifts.vue | 0 .../components/page-header-template.vue | 30 ++ .../shared/components/q-table-filters.vue | 43 +++ .../utils/pay-period-calendar-picker.vue | 67 ---- .../shared/components/utils/table-filters.vue | 42 --- src/modules/shared/types/global-interfaces.ts | 0 .../shared/types/pay-period-interface.ts | 11 +- src/modules/shared/types/q-date-details.ts | 15 - ...-chart.vue => detailed-chart-expenses.vue} | 2 +- ...rt.vue => detailed-chart-hours-worked.vue} | 2 +- ...art.vue => detailed-chart-shift-types.vue} | 4 +- ...der.vue => detailed-shift-list-header.vue} | 0 ...ts-row.vue => detailed-shift-list-row.vue} | 2 +- ...ils-shifts.vue => detailed-shift-list.vue} | 33 +- .../components/overview-list-item.vue | 123 ++++++++ .../components/overview-list.vue | 72 +++++ .../components/overview-report.vue | 80 +++++ ...t-approval-employee-overview-list-item.vue | 160 ---------- ...esheet-approval-employee-overview-list.vue | 267 ---------------- .../composables/use-timesheet-approval-api.ts | 64 ++-- .../pages/timesheet-approval-detailed.vue | 151 +++++++++ .../timesheet-approval-employee-details.vue | 164 ---------- .../pages/timesheet-approval.vue | 51 ++-- ...roval.ts => timesheet-approval-service.ts} | 10 +- .../timesheet-approval-test-constants.ts | 287 ------------------ .../types/detailed-shift-color.ts | 43 +++ ...face.ts => pay-period-employee-details.ts} | 2 + .../types/pay-period-employee-overview.ts | 82 +++++ ...ew-interface.ts => pay-period-overview.ts} | 4 +- .../types/pay-period-report-options.ts | 25 ++ ...port-interface.ts => pay-period-report.ts} | 0 ...-pay-period-overview-employee-interface.ts | 25 -- .../timesheets/services/timesheet-services.ts | 6 +- .../timesheets/types/timesheet-interface.ts | 11 +- src/stores/timesheet-store.ts | 263 ++++++++-------- src/utils/store-helpers.ts | 10 + 47 files changed, 902 insertions(+), 1275 deletions(-) rename src/{modules/shared/components/navigation/footer-bar.vue => layouts/components/main-layout-footer-bar.vue} (100%) rename src/{modules/shared/components/navigation/header-bar-avatar.vue => layouts/components/main-layout-header-bar-notification.vue} (100%) rename src/{modules/shared/components/navigation/header-bar.vue => layouts/components/main-layout-header-bar.vue} (81%) rename src/{modules/shared/components/navigation/right-drawer.vue => layouts/components/main-layout-left-drawer.vue} (93%) delete mode 100644 src/modules/shared/components/auto-logout.vue delete mode 100644 src/modules/shared/components/dialogs/dialog-account.vue delete mode 100644 src/modules/shared/components/dialogs/dialog-notification.vue delete mode 100644 src/modules/shared/components/dialogs/dialog-template-shifts.vue create mode 100644 src/modules/shared/components/page-header-template.vue create mode 100644 src/modules/shared/components/q-table-filters.vue delete mode 100644 src/modules/shared/components/utils/pay-period-calendar-picker.vue delete mode 100644 src/modules/shared/components/utils/table-filters.vue delete mode 100644 src/modules/shared/types/global-interfaces.ts delete mode 100644 src/modules/shared/types/q-date-details.ts rename src/modules/timesheet-approval/components/{graphs/timesheet-approval-employee-expenses-chart.vue => detailed-chart-expenses.vue} (95%) rename src/modules/timesheet-approval/components/{graphs/timesheet-approval-employee-details-hours-worked-chart.vue => detailed-chart-hours-worked.vue} (95%) rename src/modules/timesheet-approval/components/{graphs/timesheet-approval-employee-details-shift-types-chart.vue => detailed-chart-shift-types.vue} (89%) rename src/modules/timesheet-approval/components/{timesheet-approval-employee-details-shifts-row-header.vue => detailed-shift-list-header.vue} (100%) rename src/modules/timesheet-approval/components/{timesheet-approval-employee-details-shifts-row.vue => detailed-shift-list-row.vue} (96%) rename src/modules/timesheet-approval/components/{timesheet-approval-employee-details-shifts.vue => detailed-shift-list.vue} (65%) create mode 100644 src/modules/timesheet-approval/components/overview-list-item.vue create mode 100644 src/modules/timesheet-approval/components/overview-list.vue create mode 100644 src/modules/timesheet-approval/components/overview-report.vue delete mode 100644 src/modules/timesheet-approval/components/timesheet-approval-employee-overview-list-item.vue delete mode 100644 src/modules/timesheet-approval/components/timesheet-approval-employee-overview-list.vue create mode 100644 src/modules/timesheet-approval/pages/timesheet-approval-detailed.vue delete mode 100644 src/modules/timesheet-approval/pages/timesheet-approval-employee-details.vue rename src/modules/timesheet-approval/services/{services-timesheet-approval.ts => timesheet-approval-service.ts} (64%) delete mode 100644 src/modules/timesheet-approval/timesheet-approval-test-constants.ts create mode 100644 src/modules/timesheet-approval/types/detailed-shift-color.ts rename src/modules/timesheet-approval/types/{timesheet-approval-pay-period-employee-details-interface.ts => pay-period-employee-details.ts} (84%) create mode 100644 src/modules/timesheet-approval/types/pay-period-employee-overview.ts rename src/modules/timesheet-approval/types/{timesheet-approval-pay-period-overview-interface.ts => pay-period-overview.ts} (50%) create mode 100644 src/modules/timesheet-approval/types/pay-period-report-options.ts rename src/modules/timesheet-approval/types/{timesheet-approval-pay-period-report-interface.ts => pay-period-report.ts} (100%) delete mode 100644 src/modules/timesheet-approval/types/timesheet-approval-pay-period-overview-employee-interface.ts create mode 100644 src/utils/store-helpers.ts diff --git a/src/css/app.scss b/src/css/app.scss index e3d7a16..adfa295 100644 --- a/src/css/app.scss +++ b/src/css/app.scss @@ -31,5 +31,5 @@ body.body--dark { .body--light { --q-dark: #FFF; - color: $grey-8; + color: $blue-grey-8; } \ No newline at end of file diff --git a/src/i18n/en-ca/index.ts b/src/i18n/en-ca/index.ts index 2697fe5..c70a632 100644 --- a/src/i18n/en-ca/index.ts +++ b/src/i18n/en-ca/index.ts @@ -74,6 +74,7 @@ export default { }, label: { search: "search", + filter: "filters", loading: "loading...", language: "Language", add: "ajouter", diff --git a/src/i18n/fr-ca/index.ts b/src/i18n/fr-ca/index.ts index 4a5a9ba..f07d515 100644 --- a/src/i18n/fr-ca/index.ts +++ b/src/i18n/fr-ca/index.ts @@ -74,6 +74,7 @@ export default { }, label: { search: 'recherche', + filter: "filtres", loading: 'chargement en cours...', language: 'langue', add: "ajouter", diff --git a/src/modules/shared/components/navigation/footer-bar.vue b/src/layouts/components/main-layout-footer-bar.vue similarity index 100% rename from src/modules/shared/components/navigation/footer-bar.vue rename to src/layouts/components/main-layout-footer-bar.vue diff --git a/src/modules/shared/components/navigation/header-bar-avatar.vue b/src/layouts/components/main-layout-header-bar-notification.vue similarity index 100% rename from src/modules/shared/components/navigation/header-bar-avatar.vue rename to src/layouts/components/main-layout-header-bar-notification.vue diff --git a/src/modules/shared/components/navigation/header-bar.vue b/src/layouts/components/main-layout-header-bar.vue similarity index 81% rename from src/modules/shared/components/navigation/header-bar.vue rename to src/layouts/components/main-layout-header-bar.vue index 253fd61..8120ef7 100644 --- a/src/modules/shared/components/navigation/header-bar.vue +++ b/src/layouts/components/main-layout-header-bar.vue @@ -1,6 +1,6 @@ @@ -14,7 +14,7 @@ - + diff --git a/src/modules/shared/components/navigation/right-drawer.vue b/src/layouts/components/main-layout-left-drawer.vue similarity index 93% rename from src/modules/shared/components/navigation/right-drawer.vue rename to src/layouts/components/main-layout-left-drawer.vue index 12e9e2c..c34b1eb 100644 --- a/src/modules/shared/components/navigation/right-drawer.vue +++ b/src/layouts/components/main-layout-left-drawer.vue @@ -26,8 +26,16 @@