louis/targo-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(shifts): removed return statement of Delete shift function

Browse Source
This commit is contained in:
Matthieu Haineault 2025-10-14 14:18:31 -04:00
parent 77e10c67c7
commit 9ad4e63485
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -36,7 +36,7 @@
"seed:12": "tsx prisma/mock-seeds-scripts/12-expenses.ts", "seed:12": "tsx prisma/mock-seeds-scripts/12-expenses.ts",
"seed:13": "tsx prisma/mock-seeds-scripts/13-expenses-archive.ts", "seed:13": "tsx prisma/mock-seeds-scripts/13-expenses-archive.ts",
"seed:14": "tsx prisma/mock-seeds-scripts/14-oauth-sessions.ts", "seed:14": "tsx prisma/mock-seeds-scripts/14-oauth-sessions.ts",
"seed:all": "npm run seed:01 && npm run seed:02 && npm run seed:03 && npm run seed:04 && npm run seed:05 && npm run seed:06 && npm run seed:07 && npm run seed:08 && npm run seed:09 && npm run seed:10 && npm run seed:11 && npm run seed:12 && npm run seed:13 && npm run seed:14", "seed:all": "npm run seed:01 && npm run seed:02 && npm run seed:03 && npm run seed:09 && npm run seed:10 && npm run seed:12 && npm run seed:14",
"db:reseed": "npm run db:reset && npm run seed:all" "db:reseed": "npm run db:reset && npm run seed:all"
}, },
"dependencies": { "dependencies": {

4
src/modules/shifts/services/shifts-command.service.ts
View File

@ -164,7 +164,7 @@ export class ShiftsCommandService extends BaseApprovalService<Shifts> {
email: string, email: string,
date_iso: string, date_iso: string,
dto: UpsertShiftDto, dto: UpsertShiftDto,
): Promise<{ day: DayShiftResponse[]; }>{ ){
return this.prisma.$transaction(async (tx) => { return this.prisma.$transaction(async (tx) => {
const date_only = toDateOnly(date_iso); //converts to Date format const date_only = toDateOnly(date_iso); //converts to Date format
const employee_id = await this.emailResolver.findIdByEmail(email); const employee_id = await this.emailResolver.findIdByEmail(email);
@ -185,8 +185,6 @@ export class ShiftsCommandService extends BaseApprovalService<Shifts> {
await tx.shifts.delete({ where: { id: existing.id } }); await tx.shifts.delete({ where: { id: existing.id } });
await this.helpersService.afterWriteOvertimeAndLog(tx, employee_id, date_only); await this.helpersService.afterWriteOvertimeAndLog(tx, employee_id, date_only);
const fresh_shift = await this.helpersService.getDayShifts(tx, timesheet.id, date_only);
return { day: await this.helpersService.mapDay(fresh_shift)};
}); });
} }
} }