louis/targo-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(pay-periods): specify that is_approved can be null in controller, to not confuse false with null

Browse Source
This commit is contained in:
Nicolas Drolet 2025-12-29 08:56:22 -05:00
parent da74a93fa0
commit 7eb1471edb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/time-and-attendance/pay-period/pay-periods.controller.ts
View File

@ -52,7 +52,7 @@ export class PayPeriodsController {
): Promise<Result<{ shifts: number, expenses: number }, string>> { ): Promise<Result<{ shifts: number, expenses: number }, string>> {
if (!email) return {success: false, error: 'EMAIL_REQUIRED'}; if (!email) return {success: false, error: 'EMAIL_REQUIRED'};
if (!timesheet_ids || timesheet_ids.length < 1) return {success: false, error: 'TIMESHEET_ID_REQUIRED'}; if (!timesheet_ids || timesheet_ids.length < 1) return {success: false, error: 'TIMESHEET_ID_REQUIRED'};
if (!is_approved) return {success: false, error: 'APPROVAL_STATUS_REQUIRED'} if (is_approved === null) return {success: false, error: 'APPROVAL_STATUS_REQUIRED'}
return this.commandService.bulkApproveEmployee(email, timesheet_ids, is_approved); return this.commandService.bulkApproveEmployee(email, timesheet_ids, is_approved);
} }