From 4e48d98c0f23ed8e6d1c484eb5facfc777cae8a1 Mon Sep 17 00:00:00 2001
From: Matthieu Haineault <matthieuh@targointernet.com>
Date: Thu, 6 Nov 2025 11:10:25 -0500
Subject: [PATCH] fix(shifts): commented unused service function

---
 docs/swagger/swagger-spec.json                |  2 +-
 .../shifts/services/shifts-get.service.ts     | 52 +++++++++----------
 2 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/docs/swagger/swagger-spec.json b/docs/swagger/swagger-spec.json
index 4aad9e8..0f24da6 100644
--- a/docs/swagger/swagger-spec.json
+++ b/docs/swagger/swagger-spec.json
@@ -250,7 +250,7 @@
     },
     "/timesheets": {
       "get": {
-        "operationId": "TimesheetController_getTimesheetByIds",
+        "operationId": "TimesheetController_getTimesheetByPayPeriod",
         "parameters": [
           {
             "name": "year",
diff --git a/src/time-and-attendance/time-tracker/shifts/services/shifts-get.service.ts b/src/time-and-attendance/time-tracker/shifts/services/shifts-get.service.ts
index fb3dc48..96ae516 100644
--- a/src/time-and-attendance/time-tracker/shifts/services/shifts-get.service.ts
+++ b/src/time-and-attendance/time-tracker/shifts/services/shifts-get.service.ts
@@ -24,37 +24,37 @@ export class ShiftsGetService {
     ){}
 
     //fetch a shift using shift_id and return all that shift's info
-    async getShiftByShiftId(shift_ids: number[]): Promise<GetShiftDto[]> {
-        if(!Array.isArray(shift_ids) || shift_ids.length === 0) return [];
+    // async getShiftByShiftId(shift_ids: number[]): Promise<GetShiftDto[]> {
+    //     if(!Array.isArray(shift_ids) || shift_ids.length === 0) return [];
 
-        const rows = await this.prisma.shifts.findMany({
-            where: { id: { in: shift_ids } },
-            select: shift_select,
-        });
+    //     const rows = await this.prisma.shifts.findMany({
+    //         where: { id: { in: shift_ids } },
+    //         select: shift_select,
+    //     });
 
-        if(rows.length !== shift_ids.length) {
-            const found_ids   = new Set(rows.map(row => row.id));
-            const missing_ids = shift_ids.filter(id => !found_ids.has(id));
-            throw new NotFoundException(`Shift(s) not found: ${ missing_ids.join(", ")}`); 
-        }
+    //     if(rows.length !== shift_ids.length) {
+    //         const found_ids   = new Set(rows.map(row => row.id));
+    //         const missing_ids = shift_ids.filter(id => !found_ids.has(id));
+    //         throw new NotFoundException(`Shift(s) not found: ${ missing_ids.join(", ")}`); 
+    //     }
 
-        const row_by_id = new Map(rows.map(row => [row.id, row]));
+    //     const row_by_id = new Map(rows.map(row => [row.id, row]));
         
-        return shift_ids.map((id) => {
-            const shift = row_by_id.get(id)!;
-            return {
-                timesheet_id: shift.timesheet_id,
-                type:         shift.bank_code.type,
-                date:         toStringFromDate(shift.date),
-                start_time:   toStringFromHHmm(shift.start_time),
-                end_time:     toStringFromHHmm(shift.end_time),
-                is_remote:    shift.is_remote,
-                is_approved:  shift.is_approved,
-                comment:      shift.comment ?? undefined,
-            } satisfies GetShiftDto;
-        });
+    //     return shift_ids.map((id) => {
+    //         const shift = row_by_id.get(id)!;
+    //         return {
+    //             timesheet_id: shift.timesheet_id,
+    //             type:         shift.bank_code.type,
+    //             date:         toStringFromDate(shift.date),
+    //             start_time:   toStringFromHHmm(shift.start_time),
+    //             end_time:     toStringFromHHmm(shift.end_time),
+    //             is_remote:    shift.is_remote,
+    //             is_approved:  shift.is_approved,
+    //             comment:      shift.comment ?? undefined,
+    //         } satisfies GetShiftDto;
+    //     });
         
         
         
-    }
+    // }
 }
\ No newline at end of file