From b7b5bdfe90c8f28187826574618c85bc7ce77a92 Mon Sep 17 00:00:00 2001
From: leandrofars <leandrofars@gmail.com>
Date: Tue, 2 Jul 2024 12:32:15 -0300
Subject: [PATCH] refact(controller): user level types

---
 .../services/controller/internal/api/api.go    |  5 -----
 .../services/controller/internal/api/device.go |  3 ++-
 .../services/controller/internal/api/user.go   | 12 ++++++------
 .../services/controller/internal/db/user.go    | 18 +++++++++++++-----
 4 files changed, 21 insertions(+), 17 deletions(-)

diff --git a/backend/services/controller/internal/api/api.go b/backend/services/controller/internal/api/api.go
index 12f2626..32615cf 100644
--- a/backend/services/controller/internal/api/api.go
+++ b/backend/services/controller/internal/api/api.go
@@ -29,11 +29,6 @@ type Api struct {
 
 const REQUEST_TIMEOUT = time.Second * 30
 
-const (
-	NormalUser = iota
-	AdminUser
-)
-
 func NewApi(c *config.Config, js jetstream.JetStream, nc *nats.Conn, bridge bridge.Bridge, d db.Database, kv jetstream.KeyValue) Api {
 	return Api{
 		port:      c.RestApi.Port,
diff --git a/backend/services/controller/internal/api/device.go b/backend/services/controller/internal/api/device.go
index bcb68ea..527886c 100644
--- a/backend/services/controller/internal/api/device.go
+++ b/backend/services/controller/internal/api/device.go
@@ -8,6 +8,7 @@ import (
 	"strconv"
 
 	"github.com/leandrofars/oktopus/internal/bridge"
+	"github.com/leandrofars/oktopus/internal/db"
 	local "github.com/leandrofars/oktopus/internal/nats"
 	"github.com/leandrofars/oktopus/internal/utils"
 	"github.com/nats-io/nats.go/jetstream"
@@ -134,7 +135,7 @@ func (a *Api) deviceAuth(w http.ResponseWriter, r *http.Request) {
 		utils.MarshallEncoder(err, w)
 		return
 	}
-	if user.Level != AdminUser {
+	if user.Level != db.AdminUser {
 		w.WriteHeader(http.StatusForbidden)
 		return
 	}
diff --git a/backend/services/controller/internal/api/user.go b/backend/services/controller/internal/api/user.go
index b3893ad..f91dde7 100644
--- a/backend/services/controller/internal/api/user.go
+++ b/backend/services/controller/internal/api/user.go
@@ -51,7 +51,7 @@ func (a *Api) registerUser(w http.ResponseWriter, r *http.Request) {
 
 	//Check if user which is requesting creation has the necessary privileges
 	rUser, err := a.db.FindUser(email)
-	if rUser.Level != AdminUser {
+	if rUser.Level != db.AdminUser {
 		w.WriteHeader(http.StatusForbidden)
 		return
 	}
@@ -63,7 +63,7 @@ func (a *Api) registerUser(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	user.Level = NormalUser
+	user.Level = db.NormalUser
 
 	if err := user.HashPassword(user.Password); err != nil {
 		w.WriteHeader(http.StatusInternalServerError)
@@ -112,7 +112,7 @@ func (a *Api) deleteUser(w http.ResponseWriter, r *http.Request) {
 
 	userEmail := mux.Vars(r)["user"]
 
-	if rUser.Email == userEmail || (rUser.Level == AdminUser && rUser.Email != userEmail) { //Admin can delete any account, but admin account can never be deleted
+	if rUser.Email == userEmail || (rUser.Level == db.AdminUser && rUser.Email != userEmail) { //Admin can delete any account, but admin account can never be deleted
 		if err := a.db.DeleteUser(userEmail); err != nil {
 			w.WriteHeader(http.StatusInternalServerError)
 			json.NewEncoder(w).Encode(err)
@@ -138,7 +138,7 @@ func (a *Api) changePassword(w http.ResponseWriter, r *http.Request) {
 	userToChangePasswd := mux.Vars(r)["user"]
 	if userToChangePasswd != "" && userToChangePasswd != email {
 		rUser, _ := a.db.FindUser(email)
-		if rUser.Level != AdminUser {
+		if rUser.Level != db.AdminUser {
 			w.WriteHeader(http.StatusForbidden)
 			return
 		}
@@ -189,7 +189,7 @@ func (a *Api) registerAdminUser(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	user.Level = AdminUser
+	user.Level = db.AdminUser
 
 	if err := user.HashPassword(user.Password); err != nil {
 		w.WriteHeader(http.StatusInternalServerError)
@@ -204,7 +204,7 @@ func (a *Api) registerAdminUser(w http.ResponseWriter, r *http.Request) {
 
 func adminUserExists(users []map[string]interface{}) bool {
 	for _, x := range users {
-		if x["level"].(int32) == AdminUser {
+		if x["level"].(db.UserLevels) == db.AdminUser {
 			log.Println("Admin exists")
 			return true
 		}
diff --git a/backend/services/controller/internal/db/user.go b/backend/services/controller/internal/db/user.go
index e7e2cfc..68a4b4b 100644
--- a/backend/services/controller/internal/db/user.go
+++ b/backend/services/controller/internal/db/user.go
@@ -9,12 +9,20 @@ import (
 	"golang.org/x/crypto/bcrypt"
 )
 
+type UserLevels int32
+
+const (
+	NormalUser UserLevels = iota
+	AdminUser
+	OktopusUser
+)
+
 type User struct {
-	Email    string `json:"email"`
-	Name     string `json:"name"`
-	Password string `json:"password,omitempty"`
-	Level    int    `json:"level"`
-	Phone    string `json:"phone"`
+	Email    string     `json:"email"`
+	Name     string     `json:"name"`
+	Password string     `json:"password,omitempty"`
+	Level    UserLevels `json:"level"`
+	Phone    string     `json:"phone"`
 }
 
 var ErrorUserExists = errors.New("User already exists")