gigafibre-fsm

louis/gigafibre-fsm

Fork 0

Commit Graph

Author	SHA1	Message	Date
louispaulb	48c2f53d18	Phase 1 (hygiène) : utils partagés + logique pure testable + observabilité erp + 1ers tests Modularisation / dé-duplication : - lib/util/text.js : `norm` canonique partagé (remplace 2 ré-implémentations : address-db, legacy-dispatch-sync). - lib/util/legacy-parse.js : parseurs/mapping PURS du pont (DEPT_JOBTYPE, DUR, jobType, prio, tzDate, startTime, coord) extraits hors I/O → testables en isolation, sans pg/mysql/erp. - legacy-dispatch-sync + address-db importent ces utils (pont vérifié en prod : preview OK, 0 erreur). Observabilité (sûr, additif, 1 seul point) : - erp.js create/update/remove : log de l'échec à la SOURCE quand HTTP≥400 → toutes les écritures ERPNext silencieuses des 50+ appelants sont désormais tracées, SANS changer aucun flux de contrôle. Tests (fondation) : - vitest + npm test ; test/util.test.js : 19 tests verts sur norm + coord(bornes QC)/prio/startTime/jobType/tzDate. Tournent sans installer les deps lourdes du hub (modules purs). Aligné docs/architecture/VISION.md (P0 hygiène). Suite : audit r.ok des appelants financiers (payments/contracts) en revue supervisée ; CI/CD minimal (Gitea Actions lint+test) ; décomposition des god-files (Phase 2). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-07 10:36:41 -04:00
louispaulb	01bb99857f	refactor(targo-hub): add erp.js wrapper + migrate 7 lib files to it Replaces hand-rolled `erpFetch` + `encodeURIComponent(JSON.stringify(...))` URL building with a structured wrapper: erp.get/list/listRaw/create/update/ remove/getMany/hydrateLabels/raw. Key wins: - erp.list auto-retries up to 5 times when v16 rejects a fetched/linked field with "Field not permitted in query" — the field is dropped and the call continues, so callers don't have to know which fields v16 allows. - erp.hydrateLabels batches link-label resolution (customer_name, service_location_name, …) in one query per link field — no N+1, no v16 breakage. - Consistent {ok, error, status} shape for mutations. Migrated call sites: - otp.js: Customer email lookup + verifyOTP customer detail fetch + Contact email fallback + Service Location listing - referral.js: Referral Credit fetch / update / generate - tech-absence-sms.js: lookupTechByPhone, set/clear absence - conversation.js: Issue archive create - magic-link.js: Tech lookup for /refresh - ical.js: Tech lookup + jobs listing for iCal feed - tech-mobile.js: 13 erpFetch sites → erp wrapper Remaining erpFetch callers (dispatch.js, acceptance.js, payments.js, contracts.js, checkout.js, …) deliberately left untouched this pass — they each have 10+ sites and need individual smoke-tests. Live-tested against production ERPNext: tech-mobile page renders 54K bytes, no runtime errors in targo-hub logs post-restart. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-22 23:01:27 -04:00

Author

SHA1

Message

Date

louispaulb

48c2f53d18

Phase 1 (hygiène) : utils partagés + logique pure testable + observabilité erp + 1ers tests

Modularisation / dé-duplication :
- lib/util/text.js : `norm` canonique partagé (remplace 2 ré-implémentations : address-db, legacy-dispatch-sync).
- lib/util/legacy-parse.js : parseurs/mapping PURS du pont (DEPT_JOBTYPE, DUR, jobType, prio, tzDate,
  startTime, coord) extraits hors I/O → testables en isolation, sans pg/mysql/erp.
- legacy-dispatch-sync + address-db importent ces utils (pont vérifié en prod : preview OK, 0 erreur).

Observabilité (sûr, additif, 1 seul point) :
- erp.js create/update/remove : log de l'échec à la SOURCE quand HTTP≥400 → toutes les écritures ERPNext
  silencieuses des 50+ appelants sont désormais tracées, SANS changer aucun flux de contrôle.

Tests (fondation) :
- vitest + npm test ; test/util.test.js : 19 tests verts sur norm + coord(bornes QC)/prio/startTime/jobType/tzDate.
  Tournent sans installer les deps lourdes du hub (modules purs).

Aligné docs/architecture/VISION.md (P0 hygiène). Suite : audit r.ok des appelants financiers (payments/contracts)
en revue supervisée ; CI/CD minimal (Gitea Actions lint+test) ; décomposition des god-files (Phase 2).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-07 10:36:41 -04:00

louispaulb

01bb99857f

refactor(targo-hub): add erp.js wrapper + migrate 7 lib files to it

Replaces hand-rolled `erpFetch` + `encodeURIComponent(JSON.stringify(...))`
URL building with a structured wrapper: erp.get/list/listRaw/create/update/
remove/getMany/hydrateLabels/raw.

Key wins:
- erp.list auto-retries up to 5 times when v16 rejects a fetched/linked
  field with "Field not permitted in query" — the field is dropped and the
  call continues, so callers don't have to know which fields v16 allows.
- erp.hydrateLabels batches link-label resolution (customer_name,
  service_location_name, …) in one query per link field — no N+1, no
  v16 breakage.
- Consistent {ok, error, status} shape for mutations.

Migrated call sites:
- otp.js: Customer email lookup + verifyOTP customer detail fetch +
  Contact email fallback + Service Location listing
- referral.js: Referral Credit fetch / update / generate
- tech-absence-sms.js: lookupTechByPhone, set/clear absence
- conversation.js: Issue archive create
- magic-link.js: Tech lookup for /refresh
- ical.js: Tech lookup + jobs listing for iCal feed
- tech-mobile.js: 13 erpFetch sites → erp wrapper

Remaining erpFetch callers (dispatch.js, acceptance.js, payments.js,
contracts.js, checkout.js, …) deliberately left untouched this pass —
they each have 10+ sites and need individual smoke-tests.

Live-tested against production ERPNext: tech-mobile page renders 54K
bytes, no runtime errors in targo-hub logs post-restart.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

2026-04-22 23:01:27 -04:00

2 Commits